launch prep: FLUSHALL, MEMORY USAGE, and docs clarity - #324
Merged
Conversation
FLUSHALL [ASYNC] is an alias for FLUSHDB — ember is single-database, so the behavior is identical. it's a high-visibility command that redis users reach for immediately when setting up a fresh environment. MEMORY USAGE key [SAMPLES count] returns the estimated memory footprint of a key in bytes using the cached value size on each entry (O(1), no collection walk). the SAMPLES option is accepted and silently ignored since ember's estimate is always based on the cached size. returns nil if the key does not exist or is expired.
…ed section - FLUSHALL and MEMORY USAGE rows updated in compatibility matrix - geo commands changed from "not implemented yet" to "coming in a future release" - lua scripting exclusion made explicit (not just anti-goal; not planned) - new "not supported" section in README listing excluded features with rationale - new "notable differences from redis" section covering shard rename semantics, transaction atomicity, and the RESP3 vs gRPC port split
kacy
added a commit
that referenced
this pull request
Feb 27, 2026
bitop dispatched all work to dest's shard, so source keys on other shards were read as empty buffers — producing wrong results. fix reads each source from its own shard via route_multi, computes the bitwise result in the connection layer, then writes to dest's shard. also fixes cli command sort order: FLUSHALL was added after FLUSHDB (pr #324) and MEMORY USAGE was placed before INFO, both violating the alphabetical invariant checked by commands_sorted_within_groups.
kacy
added a commit
that referenced
this pull request
Feb 27, 2026
bitop dispatched all work to dest's shard, so source keys on other shards were read as empty buffers — producing wrong results. fix reads each source from its own shard via route_multi, computes the bitwise result in the connection layer, then writes to dest's shard. also fixes cli command sort order: FLUSHALL was added after FLUSHDB (pr #324) and MEMORY USAGE was placed before INFO, both violating the alphabetical invariant checked by commands_sorted_within_groups.
kacy
added a commit
that referenced
this pull request
Feb 27, 2026
* fix: bitop cross-shard read; fix cli command sort order bitop dispatched all work to dest's shard, so source keys on other shards were read as empty buffers — producing wrong results. fix reads each source from its own shard via route_multi, computes the bitwise result in the connection layer, then writes to dest's shard. also fixes cli command sort order: FLUSHALL was added after FLUSHDB (pr #324) and MEMORY USAGE was placed before INFO, both violating the alphabetical invariant checked by commands_sorted_within_groups. * docs: update test count to 1,690+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
pre-launch polish before developer community launch.
new commands:
FLUSHALL [ASYNC]— alias for FLUSHDB (ember is single-database); high-visibility Redis command that users reach for immediatelyMEMORY USAGE key [SAMPLES count]— returns estimated key memory in bytes using the existing cached value size; useful for production debuggingdocumentation:
what was tested
cargo buildpasses cleanly